mburchard/vite-electron-starter
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix(dialog): merge partial placement with defaults instead of replacing #13

Merged
mburchard merged 1 commit from fix/dialog-placement-merge into main 2026-03-11 18:02:18 +00:00
Conversation 0 Commits 1 Files changed 2 +27 -1
mburchard commented 2026-03-11 17:59:45 +00:00
Owner
Copy link
  • Spread caller placement into default placement so individual properties like screen can be set without losing horizontal/top defaults
  • Add test verifying partial placement merge preserves defaults
- Spread caller placement into default placement so individual properties like screen can be set without losing horizontal/top defaults - Add test verifying partial placement merge preserves defaults
fix(dialog): merge partial placement with defaults instead of replacing
All checks were successful
CI / ci (pull_request) Successful in 1m52s
Details
CI / ci (push) Successful in 1m51s
Details
d207111c6f 
- Spread caller placement into default placement so individual properties like screen can be
  set without losing horizontal/top defaults
- Add test verifying partial placement merge preserves defaults
mburchard deleted branch fix/dialog-placement-merge 2026-03-11 18:02:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mburchard/vite-electron-starter!13
No description provided.